Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to disallow activeset fetching via hs/1 (hash) protocol #5928

Open
ivan4th opened this issue May 10, 2024 · 0 comments
Open

Need to disallow activeset fetching via hs/1 (hash) protocol #5928

ivan4th opened this issue May 10, 2024 · 0 comments
Labels

Comments

@ivan4th
Copy link
Contributor

ivan4th commented May 10, 2024

Description

Given that almost all the users have upgraded to the version that supports a separate protocol (as/1) for active sets, we can disallow activeset fetching using hs/1 (normal hash protocol) to avoid possible overload scenarios, in which activeset requests are subject to normal hash blob pacers.

Steps to reproduce

Request activesets using hs/1 protocol

Actual Behavior

Requests succeed, subject to hs/1 pacer setting

Expected Behavior

Activesets not allowed to be fetched via hs/1, only via as/1

@ivan4th ivan4th added the bug label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant