We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hash.Hash
sync.Pool
This issue came up in a discussion here: #5784 (comment)
Every time the node hashes data it re-instantiates hash.Hash objects, which is slow and can be mitigated by using a sync.Pool.
An example would be here:
go-spacemesh/common/types/wire/activation_v1.go
Line 129 in 28480f5
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
This issue came up in a discussion here: #5784 (comment)
Every time the node hashes data it re-instantiates
hash.Hash
objects, which is slow and can be mitigated by using async.Pool
.Affected code
An example would be here:
go-spacemesh/common/types/wire/activation_v1.go
Line 129 in 28480f5
Other places where instances of hash are created should also be checked to be re-used.
The text was updated successfully, but these errors were encountered: