Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce NOT NULL on the atxs.nonce column and atomicity during sql.atxs.Add() #5844

Open
ivan4th opened this issue Apr 12, 2024 · 0 comments

Comments

@ivan4th
Copy link
Contributor

ivan4th commented Apr 12, 2024

Description

There are a lot of tests that don't care about ATX nonces and previous ATX IDs, and because of them it's not possible to use NOT NULL on the atxs.nonce column.
Another problem is that sql.atxs.Add may cause problems if it's not used within a transaction, so it should better accept *sql.Tx instead of an Executor as an argument.
Both problems require modification of mostly same tests so using a single issue for both.

Affected code

Tests that create ATXs but don't properly set nonces and prev ATX IDs

Problem appeared after #5791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant