Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextually invalid atx is stored in the state and used for consensus #5692

Closed
dshulyak opened this issue Mar 13, 2024 · 0 comments
Closed
Assignees
Labels

Comments

@dshulyak
Copy link
Contributor

dshulyak commented Mar 13, 2024

there are plenty of logs like

2024-03-13T10:19:12.695+0100	WARN	node.atxHandler	atx failed contextual validation	{"sessionId": "e5aa86a0", "atx_id": "d0463ea83cdb0972a3fb9f9ad06c5c197a6a688d02cc575ebe1d123cf5d9b8e2", "smesher": "27ddd733fe3b2299633eb78576fc2b294aca2457d7b8b01b6d2f9cfa33129c91", "errmsg": "last atx is not the one referenced", "name": "atxHandler"}
2024-03-13T10:19:12.734+0100	WARN	node.atxHandler	atx failed contextual validation	{"sessionId": "e5aa86a0", "atx_id": "0d87313d13a71c44b860cad960da8ec1268dafabf2a23dc792e9676d44943fc8", "smesher": "04163ae9d30c94beedf6331f7dea245654537dde879867908e6e0469d1786ebd", "errmsg": "last atx is not the one referenced", "name": "atxHandler"}
2024-03-13T10:19:12.845+0100	WARN	node.atxHandler	atx failed contextual validation	{"sessionId": "e5aa86a0", "atx_id": "b48940a10536ad46e7ee51082ee8c93094ebbd48c8e42e3e87d4bcb6b26d4c89", "smesher": "25fdff97f4f5a04662293b852871607afdf7ef3c78d9c0e193c1861d3b600dd2", "errmsg": "no prev atx reported, but other atx with same node id (25fdff97f4f5a04662293b852871607afdf7ef3c78d9c0e193c1861d3b600dd2) found: 1a53b2994e", "name": "atxHandler"}

however such atxs are not marked as contextually invalid, and ballots from those atxs will be normally counted, and proposals will be rewarded. this seems like an oversight in the validation.

@fasmat fasmat self-assigned this Mar 13, 2024
spacemesh-bors bot pushed a commit that referenced this issue May 21, 2024
… ATXs (#5927)

## Motivation

This integrates the changes from the CVE fix into the main development branch.

Closes #5692



Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
spacemesh-bors bot pushed a commit that referenced this issue May 21, 2024
… ATXs (#5927)

## Motivation

This integrates the changes from the CVE fix into the main development branch.

Closes #5692



Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants