Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch Alarms #484

Open
jfpaulin opened this issue Jan 10, 2024 · 4 comments
Open

Cloudwatch Alarms #484

jfpaulin opened this issue Jan 10, 2024 · 4 comments
Labels
Feature Request Enhancement to existing functionality or new functionality

Comments

@jfpaulin
Copy link

🙍 Problem Statement

I'm currently changing the way I'm creating alarms in AWS Cloudwatch. I was using the AWS CLI but now I want to use this cookbook.
The problem I have is that when I was creating alarms using CLI, I could set the value for "Missing data treatment" using this parameter here :
--treat-missing-data breaching
It does not seem to be possible right now using the latest cookbook's version.

❔ Possible Solution

Maybe just adding a new property for the resource and use that property when creating the alarm.

Thanks for your help.

@jfpaulin jfpaulin added the Feature Request Enhancement to existing functionality or new functionality label Jan 10, 2024
@majormoses
Copy link
Contributor

👋 I took a look and I think it might be supported, can you confirm if insufficient_data_actions is what you are looking for?

https://github.com/sous-chefs/aws/blob/v8.3.1/resources/cloudwatch.rb#L6

@jfpaulin
Copy link
Author

jfpaulin commented Jan 10, 2024

Thanks for your answer, but no. Using insufficient_data_actions tells CloudWatch what action to take when the alarm falls into Insufficient data state.

--treat-missing-data breaching tells CloudWatch that when there is no data found, the alarm should be put in Alarm state.

Thanks again!

@majormoses
Copy link
Contributor

majormoses commented Jan 10, 2024

I see; it looks like we would need to add treat_missing_data to the options in the section I linked above, with the possible values of (breaching | notBreaching | ignore | missing), and a default of missing based on your explanation and a quick review of https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/CloudWatch/Client.html. I am happy to review it if someone wants to take a crack at this.

@jfpaulin
Copy link
Author

I would be happy to help. Can I contribute using the guidelines found here : https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/CONTRIBUTING.MD ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality
Projects
None yet
Development

No branches or pull requests

2 participants