Make sure that already attached EBS volume is registered in the node data

[maxnasonov]

Cookbook version

6.1.1

Chef-client version

12.5.1

Steps to Reproduce:

1. Attach EBS volume manually or delete existing node data for the volume
2. Trigger attach action on aws_ebs_volume resource

Expected Result:

The volume is registered as a node attribute

Actual Result:

The volume is not registered as a node attribute

[tas50]

I ran into this the other day. It's breaking the detach action right now.

[tas50]

The real solution here is not to use the node to save state. That's an inherently flawed method of storing ec2 state. I'm noodling on either using tags to store this same data in ec2 or relying on an ohai plugin for ebs volume information.

[glasschef]

Similarly, if the ebs volume gets deleted by other means (like the console, for example), the old volume id is still saved in node data and will fail when trying to create a new volume:

 ---------------------
    # In /var/chef/cache/cookbooks/ebstest/recipes/default.rb

      7: aws_ebs_volume 'standard_ebs_vol_with_tags' do
      8:   size 1
      9:   device '/dev/sdk'
     10:   tags('Environment' => 'test_kitchen')
     11:   delete_on_termination true
     12:   action [:create, :attach]
     13: end

[2018-08-28T23:05:03+00:00] FATAL: Aws::EC2::Errors::InvalidVolumeNotFound: aws_ebs_volume[standard_ebs_vol_with_tags] (ebstest::default line 7) had an error: Aws::EC2::Errors::InvalidVolumeNotFound: The volume 'vol-0a4707b0c00a7ce18' does not exist.

 "aws": {
      "ebs_volume": {
        "standard_ebs_vol_with_tags": {
          "volume_id": "vol-0a4707b0c00a7ce18"
        }
      }