Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ELBv2 #252

Open
eherot opened this issue Aug 11, 2016 · 8 comments
Open

Add support for ELBv2 #252

eherot opened this issue Aug 11, 2016 · 8 comments

Comments

@eherot
Copy link
Contributor

eherot commented Aug 11, 2016

@tas50
Copy link
Contributor

tas50 commented Aug 11, 2016

We're looking forward to a PR that supports the new appliation load balancers, but it doesn't look like the api even supports this yet. The docs still reference the old API rev. We'll have to wait and see when Amazon releases their gem with updated support

@eherot
Copy link
Contributor Author

eherot commented Aug 12, 2016

Perhaps I'm misinterpreting the response but it definitely looks like the new version of aws-sdk supports ELBv2:

This target group is one that I made through the console:

$ pry -raws-sdk
[1] pry(main)> elbv2 = Aws::ElasticLoadBalancingV2::Client.new
=> #<Aws::ElasticLoadBalancingV2::Client>
[2] pry(main)> elbv2.describe_target_groups
=> #<struct Aws::ElasticLoadBalancingV2::Types::DescribeTargetGroupsOutput
 target_groups=
  [#<struct Aws::ElasticLoadBalancingV2::Types::TargetGroup
    target_group_arn="arn:aws:elasticloadbalancing:us-east-1:REDACTED:targetgroup/test-target-group/REDACTED",
    target_group_name="test-target-group",
    protocol="HTTP",
    port=80,
    vpc_id="vpc-REDACTED",
    health_check_protocol="HTTP",
    health_check_port="traffic-port",
    health_check_interval_seconds=30,
    health_check_timeout_seconds=10,
    healthy_threshold_count=10,
    unhealthy_threshold_count=2,
    health_check_path="/",
    matcher=#<struct Aws::ElasticLoadBalancingV2::Types::Matcher http_code="200">,
    load_balancer_arns=
     ["arn:aws:elasticloadbalancing:us-east-1:REDACTED:loadbalancer/app/test-app-lb/REDACTED"]>],
 next_marker=nil>

I haven't tried making any modifications yet but I have no reason to believe they won't work.

Unfortunately of course there are no ruby docs (yet?) for the new SDK but you can sort of piece your way through the commands by reading the model JSON.

PS. I'm actually working on a PR right now so if I can manage to get it done in a reasonable amount of time I'll try to address my own issue. ;-)

@iennae
Copy link
Contributor

iennae commented Nov 7, 2016

@eherot did you happen to get anywhere with your PR? Thanks!

@eherot
Copy link
Contributor Author

eherot commented Nov 8, 2016

@iennae I got some work done. Here's the WIP PR if you want to try to contribute to it in the mean time: #265

@bruce-davis
Copy link

@eherot Do you have more updates to your PR?

@eherot
Copy link
Contributor Author

eherot commented Feb 13, 2017

Negative. Sorry!

@nickpetrovic
Copy link

This would be very helpful for instances managed by OpsWorks since it doesn't support ALB (ELB v2) yet. Looking forward to this feature.

@tmcneill-mbo
Copy link

Any update on when ALB's will be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants