Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters for left-most column remain disabled after clearing Task Filter #1032

Closed
JawHawk opened this issue Apr 26, 2024 · 6 comments · Fixed by #1040
Closed

Filters for left-most column remain disabled after clearing Task Filter #1032

JawHawk opened this issue Apr 26, 2024 · 6 comments · Fixed by #1040

Comments

@JawHawk
Copy link
Member

JawHawk commented Apr 26, 2024

Column filters are disabled when Task filter is applied. But even after clearing Task filter, column filters are disabled and shows message To edit, please clear task filter in the sidebar. The page needs to be refreshed to enable to column filters again. I think, the expected behavior should be to enable column filters whenever Task Filter is removed.
Following is the recording of the same.

resettaskfiltererror-2024-04-26_17.09.28.mp4
@PhilippWendler
Copy link
Member

Just to be sure, with "column filters" you are only referring to the filter on the left-most column, right?

Indeed, what you showed is a bug and you are also fully correct about the expected behavior. Thank you for bringing this up!

@JawHawk
Copy link
Member Author

JawHawk commented May 9, 2024

Yes, I refer to the left-most column.
Also if any filter is applied in other columns, it is directly reflected in columns filter input. For example, see below -
image
image

So should the same be done in case of id filter column or just display text To edit, please clear task filter in the sidebar as before when any task filters are applied.

@PhilippWendler PhilippWendler changed the title Column filters disabled after clearing Task Filter Filters for left-most column remain disabled after clearing Task Filter May 13, 2024
@JawHawk
Copy link
Member Author

JawHawk commented May 16, 2024

Also if any filter is applied in other columns, it is directly reflected in columns filter input.
So should the same be done in case of id filter column or just display text To edit, please clear task filter in the sidebar as before when any task filters are applied.

@PhilippWendler What should be done ? I kindly want to resolve this issue.

@PhilippWendler
Copy link
Member

Sorry, I didn't realize there was an open question.

If one configures a task filter in the sidebar, we have not yet found a good way how to make this visible and interactive in the filter row. The reason for this is that in the side bar, you configure filters separately for task id, property, etc., whereas if you enter something in the left most column of the filter row, it applies to all of task id, property, etc. together. So the semantics are different. This is why we show To edit, please clear task filter in the sidebar once the sidebar has been used to configure a task filter.

We can keep this (but if you have an idea to improve it, please share!). To fix the bug it would suffice that the filter row becomes usable again whenever a task filter is removed.

@JawHawk
Copy link
Member Author

JawHawk commented May 17, 2024

Got it.
One way can be to provide a select dropdown for all task_id_names. The input element will have value corresponding to the task_id_name selected like below.
image

Other can be to provide a collapsible option for each task_id_name.

ko-2024-05-17_16.48.19.mp4

It will have some indication like green dot if it's corresponding input has some value. Same green dot can be shown in selection dropdown so that user don't have to select different task_id_name again & again to see if it has some value. Which one is preferable or should I move on with To edit, please clear task filter in the sidebar ?

@PhilippWendler
Copy link
Member

Very interesting, thanks for the suggestions! I am not sure what I prefer, but I think we should eventually use one of your ideas.

In the meantime, how about fixing just the bug first and keep the fix separate from the new feature?

PhilippWendler added a commit that referenced this issue May 23, 2024
Fixes #1032
---------

Co-authored-by: Philipp Wendler <uni@philippwendler.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants