Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed correct classname in README and add missing use statements #148

Merged
merged 1 commit into from Mar 24, 2017

Conversation

eko
Copy link
Contributor

@eko eko commented Mar 20, 2017

Subject

Fixed correct classname in README and add missing use statements.

Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a meaningful commit messages describing what you fixed rather than in what file you fixed it: "use correct class name" and "add missing use statements

@eko eko changed the title Fixed README.md Fixed correct classname in README and add missing use statements Mar 24, 2017
@eko
Copy link
Contributor Author

eko commented Mar 24, 2017

@greg0ire You're right, I've fixed the commit message and pull request title.

@jordisala1991 jordisala1991 merged commit 069f517 into sonata-project:1.x Mar 24, 2017
@jordisala1991
Copy link
Member

Thanks @eko

@greg0ire
Copy link
Contributor

Thanks @eko , next time consider even doing 2 commits (with "git add -p"), if you have "and" in your commit message, it's a smell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants