Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reset password optional #1491

Open
jordisala1991 opened this issue Feb 3, 2022 · 1 comment · May be fixed by #1576
Open

Make reset password optional #1491

jordisala1991 opened this issue Feb 3, 2022 · 1 comment · May be fixed by #1576
Milestone

Comments

@jordisala1991
Copy link
Member

Feature Request

It would be nice to enable / disable reset password and avoid dependencies with mailer.

Extracted from: #1465

@jordisala1991 jordisala1991 added this to the 6.0 milestone Feb 10, 2022
@Hanmac
Copy link
Contributor

Hanmac commented Oct 13, 2022

I'm currently brainstorming about this one, where i try to think of the possible constellations and how they should react:

  • first it should check if there are resetting values, if not, then a big chunk doesn't need to be configured.
    • there doesn't need to be reset routes, and the link in template doesn't need to be there either
    • without resetting there doesn't need to be sonata user mailer, and also no symfony mailer
  • then should it be possible to disable the resetting by disabling the sonata_user.mailer config?
  • when having a custom mailer, then it doesn't need to complain about symfony mailer

any other should complain about missing services, right?

and if the resetting should work without admin bundle

@Hanmac Hanmac linked a pull request Oct 13, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants