Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch cocur/slugify to symfony/string #1713

Open
eerison opened this issue Sep 8, 2023 · 3 comments · May be fixed by #1718
Open

Switch cocur/slugify to symfony/string #1713

eerison opened this issue Sep 8, 2023 · 3 comments · May be fixed by #1718
Labels
feature

Comments

@eerison
Copy link
Contributor

eerison commented Sep 8, 2023 •
edited

Switch cocur/slugify to symfony/string

in order to use more symfony packages and keep this repo using the same dependencies as admin bundle

I suggest we change slugify to symfony/string!

in case it makes sense, then I will try to do it :D
@eerison eerison added the feature label Sep 8, 2023
@VincentLanglet
Copy link
Member

in case it makes sense, then I will try to do it :D

Sure it make sense ; but I dunno if we'll be able to drop the dependency in a BC way.

Pr is opened.

@eerison
Copy link
Contributor Author

eerison commented Sep 8, 2023 •
edited

Yeah, we need to keep the dependency in 4.x and remove in 5.x only.

We need the both dependencies to keep BC compatibility

eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Oct 11, 2023
Feature/1713 - Switch slugify for symfony string
1325fce 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
@eerison eerison linked a pull request Oct 11, 2023 that will close this issue
Draft
eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Dec 1, 2023
@eerison
Feature/1713 - Switch slugify for symfony string
7c87149 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Jan 3, 2024
@eerison
Feature/1713 - Switch slugify for symfony string
762ed39 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Jan 3, 2024
@eerison
Feature/1713 - Switch slugify for symfony string
56dcb0a 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Jan 3, 2024
@eerison
Feature/1713 - Switch slugify for symfony string
dd239c4 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
eerison pushed a commit to eerison/SonataPageBundle that referenced this issue Jan 3, 2024
@eerison
Feature/1713 - Switch slugify for symfony string
708060f 
- Refactored fixUrl method and created more unit tests.

Issue sonata-project#1713
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1713 - Switch slugify to symfony string eerison/SonataPageBundle
2 participants
@eerison @VincentLanglet