Feature/1713 - Switch slugify to symfony string #1718
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerison
force-pushed
the
feature/1713_switch-slugfy-to-symfony-string
branch
from
1325fce
to
7c87149
Compare
eerison
force-pushed
the
feature/1713_switch-slugfy-to-symfony-string
branch
3 times, most recently
from
56dcb0a
to
dd239c4
Compare
- Refactored fixUrl method and created more unit tests. Issue sonata-project#1713
eerison
force-pushed
the
feature/1713_switch-slugfy-to-symfony-string
branch
from
dd239c4
to
708060f
Compare
eerison
changed the title
VincentLanglet
requested changes
Jan 22, 2024
| @@ -35,7 +37,7 @@ final class PageManager extends BaseEntityManager implements PageManagerInterfac | |||
| public function __construct( | |||
| string $class, | |||
| ManagerRegistry $registry, | |||
| private SlugifyInterface $slugify, | |||
| private SlugifyInterface|SluggerInterface $slugger, | |||
There was a problem hiding this comment.
You need to add a deprecation if the slugger passed is not instance of SluggerInterface.
And a next major comment to reduce the param to sluggerInterface.
| $slug = $page->getSlug(); | ||
|
|
||
| // NEXT_MAJOR: Remove Slugify support | ||
| if (null === $slug && $this->slugger instanceof Slugify) { |
There was a problem hiding this comment.
Suggested change
| if (null === $slug && $this->slugger instanceof Slugify) { | |
| if (null === $slug && $this->slugger instanceof SlugifyInterface) { |
no?
and might be better to write
Suggested change
| if (null === $slug && $this->slugger instanceof Slugify) { | |
| if (null === $slug && !$this->slugger instanceof SluggerInterface) { |
| if (null === $slug && $this->slugger instanceof Slugify) { | ||
| @trigger_error(sprintf( | ||
| '%s is deprecated since version 4.8.0 and will be removed in 5.0, use %s instead of.', | ||
| Slugify::class, |
There was a problem hiding this comment.
Suggested change
| Slugify::class, | |
| SlugifyInterface::class, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace slugify to symfony string
Closes #1713.
Changelog