Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Composer (Compose page blocks) gives incorrect position to new created block after deleting few of them #1642

Open
AVAW opened this issue Nov 14, 2022 · 2 comments

Comments

@AVAW
Copy link

AVAW commented Nov 14, 2022

Environment

Sonata packages

show

sonata-project/admin-bundle              3.107.3 4.21.0 The missing Symfony Admin Generator
sonata-project/block-bundle              3.21.0  4.19.0 Symfony SonataBlockBundle
sonata-project/cache                     2.0.1   2.2.0  Cache library
Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/cache-bundle              3.4.0   3.4.0  This bundle provides caching services
Package sonata-project/cache-bundle is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/datagrid-bundle           2.5.0   3.5.0  Symfony SonataDatagridBundle
Package sonata-project/datagrid-bundle is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/doctrine-extensions       1.9.1   1.18.1 Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 3.35.3  4.8.0  Integrate Doctrine ORM into the SonataAdminBundle
sonata-project/easy-extends-bundle       2.5.0   2.5.0  Symfony SonataEasyExtendsBundle
Package sonata-project/easy-extends-bundle is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/exporter                  2.7.0   2.13.0 Lightweight Exporter library
sonata-project/form-extensions           1.6.0   1.18.0 Symfony form extensions
sonata-project/formatter-bundle          4.6.1   5.0.1  Symfony SonataFormatterBundle
sonata-project/media-bundle              3.28.0  4.5.1  Symfony SonataMediaBundle
sonata-project/notification-bundle       3.9.0   3.13.0 Symfony SonataNotificationBundle
Package sonata-project/notification-bundle is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/page-bundle               3.26.0  3.29.0 This bundle provides a Site and Page management through container and block services
sonata-project/seo-bundle                2.15.0  3.5.0  Symfony SonataSeoBundle
sonata-project/translation-bundle        2.10.1  3.1.0  SonataTranslationBundle
sonata-project/twig-extensions           1.10.0  1.12.0 Sonata twig extensions

Symfony packages

show

symfony/acl-bundle                 v2.3.0  v2.3.0  Symfony AclBundle
symfony/asset                      v4.4.40 v5.4.13 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files
symfony/browser-kit                v4.4.37 v5.4.11 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically
symfony/cache                      v4.4.41 v5.4.15 Provides an extended PSR-6, PSR-16 (and tags) implementation
symfony/cache-contracts            v2.5.2  v2.5.2  Generic abstractions related to caching
symfony/config                     v4.4.41 v5.4.11 Helps you find, load, combine, autofill and validate configuration values of any kind
symfony/console                    v4.4.43 v5.4.15 Eases the creation of beautiful and testable command line interfaces
symfony/css-selector               v4.4.37 v5.4.11 Converts CSS selectors to XPath expressions
symfony/debug                      v4.4.44 v4.4.44 Provides tools to ease debugging PHP code
Package symfony/debug is abandoned, you should avoid using it. Use symfony/error-handler instead.
symfony/dependency-injection       v4.4.41 v5.4.13 Allows you to standardize and centralize the way objects are constructed in your application
symfony/deprecation-contracts      v2.5.2  v2.5.2  A generic function and convention to trigger deprecation notices
symfony/doctrine-bridge            v4.4.41 v5.4.15 Provides integration for Doctrine with various Symfony components
symfony/dom-crawler                v4.4.42 v5.4.15 Eases DOM navigation for HTML and XML documents
symfony/dotenv                     v4.4.37 v5.4.5  Registers environment variables from a .env file
symfony/error-handler              v4.4.44 v5.4.15 Provides tools to manage errors and ease debugging PHP code
symfony/event-dispatcher           v4.4.44 v5.4.9  Provides tools that allow your application components to communicate with each other by dispatching events and listening to them
symfony/event-dispatcher-contracts v1.1.13 v2.5.2  Generic abstractions related to dispatching event
symfony/expression-language        v4.4.41 v5.4.14 Provides an engine that can compile and evaluate expressions
symfony/filesystem                 v4.4.39 v5.4.13 Provides basic utilities for the filesystem
symfony/finder                     v4.4.41 v5.4.11 Finds files and directories via an intuitive fluent interface
symfony/flex                       v1.18.7 v1.19.3 Composer plugin for Symfony
symfony/form                       v4.4.41 v5.4.15 Allows to easily create, process and reuse HTML forms
symfony/framework-bundle           v4.4.41 v5.4.14 Provides a tight integration between Symfony components and the Symfony full-stack framework
symfony/http-client                v4.4.42 v5.4.15 Provides powerful methods to fetch HTTP resources synchronously or asynchronously
symfony/http-client-contracts      v2.5.2  v2.5.2  Generic abstractions related to HTTP clients
symfony/http-foundation            v4.4.46 v5.4.15 Defines an object-oriented layer for the HTTP specification
symfony/http-kernel                v4.4.46 v5.4.15 Provides a structured process for converting a Request into a Response
symfony/inflector                  v4.4.44 v5.4.11 Converts words between their singular and plural forms (English only)
Package symfony/inflector is abandoned, you should avoid using it. Use EnglishInflector from the String component instead.
symfony/intl                       v4.4.41 v5.4.15 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library
symfony/maker-bundle               v1.39.0 v1.43.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code.
symfony/mime                       v4.4.46 v5.4.14 Allows manipulating MIME messages
symfony/monolog-bridge             v4.4.37 v5.4.10 Provides integration for Monolog with various Symfony components
symfony/monolog-bundle             v3.8.0  v3.8.0  Symfony MonologBundle
symfony/options-resolver           v4.4.37 v5.4.11 Provides an improved replacement for the array_replace PHP function
symfony/phpunit-bridge             v4.4.41 v6.1.6  Provides utilities for PHPUnit, especially user deprecation notices management
symfony/polyfill-apcu              v1.25.0 v1.27.0 Symfony polyfill backporting apcu_* functions to lower PHP versions
symfony/polyfill-ctype             v1.26.0 v1.27.0 Symfony polyfill for ctype functions
symfony/polyfill-iconv             v1.25.0 v1.27.0 Symfony polyfill for the Iconv extension
symfony/polyfill-intl-grapheme     v1.26.0 v1.27.0 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-icu          v1.25.0 v1.27.0 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn          v1.26.0 v1.27.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer   v1.26.0 v1.27.0 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring          v1.26.0 v1.27.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php72             v1.26.0 v1.27.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73             v1.26.0 v1.27.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-php80             v1.26.0 v1.27.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/polyfill-php81             v1.25.0 v1.27.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions
symfony/process                    v4.4.41 v5.4.11 Executes commands in sub-processes
symfony/property-access            v4.4.44 v5.4.15 Provides functions to read and write from/to an object or array using a simple string notation
symfony/property-info              v4.4.44 v5.4.15 Extracts information about PHP class' properties using metadata of popular sources
symfony/requirements-checker       v2.0.1  v2.0.1  Check Symfony requirements and give recommendations
symfony/routing                    v4.4.41 v5.4.15 Maps an HTTP request to a set of configuration variables
symfony/security-acl               v3.3.1  v3.3.2  Symfony Security Component - ACL (Access Control List)
symfony/security-bundle            v4.4.41 v5.4.11 Provides a tight integration of the Security component into the Symfony full-stack framework
symfony/security-core              v4.4.41 v5.4.15 Symfony Security Component - Core Library
symfony/security-csrf              v4.4.37 v5.4.11 Symfony Security Component - CSRF Library
symfony/security-guard             v4.4.37 v5.4.13 Symfony Security Component - Guard
symfony/security-http              v4.4.41 v5.4.15 Symfony Security Component - HTTP Integration
symfony/serializer                 v4.4.45 v5.4.15 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON.
symfony/service-contracts          v2.5.2  v2.5.2  Generic abstractions related to writing services
symfony/stopwatch                  v4.4.38 v5.4.13 Provides a way to profile code
symfony/string                     v5.4.13 v5.4.15 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way
symfony/swiftmailer-bundle         v3.5.4  v3.5.4  Symfony SwiftmailerBundle
Package symfony/swiftmailer-bundle is abandoned, you should avoid using it. Use symfony/mailer instead.
symfony/templating                 v4.4.37 v5.4.11 Provides all the tools needed to build any kind of template system
symfony/translation                v4.4.41 v5.4.14 Provides tools to internationalize your application
symfony/translation-contracts      v2.5.2  v2.5.2  Generic abstractions related to translation
symfony/twig-bridge                v4.4.41 v5.4.14 Provides integration for Twig with various Symfony components
symfony/twig-bundle                v4.4.41 v5.4.8  Provides a tight integration of Twig into the Symfony full-stack framework
symfony/validator                  v4.4.41 v5.4.15 Provides tools to validate values
symfony/var-dumper                 v4.4.41 v5.4.14 Provides mechanisms for walking through any arbitrary PHP variable
symfony/var-exporter               v4.4.41 v5.4.10 Allows exporting any serializable PHP data structure to plain PHP code
symfony/web-profiler-bundle        v4.4.41 v5.4.14 Provides a development tool that gives detailed information about the execution of any request
symfony/yaml                       v4.4.43 v5.4.14 Loads and dumps YAML files

PHP version

PHP 7.4.28 (cli) (built: Mar 29 2022 03:26:50) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.28, Copyright (c), by Zend Technologies
    with Xdebug v3.1.4, Copyright (c) 2002-2022, by Derick Rethans

Subject

Composer (Compose page) in admin panel when editing page blocks.
image

Steps to reproduce

  1. Create 6 blocks (names: from 1 to 6)
    image
  2. Remove first 3 blocks (from top of the list - blocks from 1 to 3)
    image
  3. Create new block - name it 7
    image
  4. Refresh page
    image

So this is how it looks in database:
image
They new block (name 7) has incorrect position: 4 - the same as the block with name 4.

I think front-end is sending incorrect position to back-end - it took it from it:
image

Expected results

Last created block should be last.

Actual results

Last created block is 2nd.

@haivala
Copy link
Contributor

haivala commented Nov 30, 2022

I'm seeing this as an feature more than a bug. You should always drag and drop the newly created block to it's right place so that the position is updated properly.

Pull requests are welcome if you think this is something that should be fixed.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants