Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substantial overhead when logging Dynamic Metadata in Access Logging #9364

Closed
DuncanDoyle opened this issue Apr 15, 2024 · 1 comment
Closed
Assignees
Labels
daily-update Issues that require a daily update Prioritized Indicating issue prioritized to be worked on in RFE stream Type: Bug Something isn't working

Comments

@DuncanDoyle
Copy link
Contributor

DuncanDoyle commented Apr 15, 2024

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.16.6

Kubernetes Version

?

Describe the bug

We found that every DYNAMIC_METADATA log field penalty is ~10 microseconds in P50th and 20+ microseconds in P99th. The regular “key: value” log field penalty is ~1.7 microseconds in P50 and 3.3 in P99th.

The tests were done on the same cluster using k6 loadgen tool and nginx (openResty) simulated backend. The results were almost similar while set_metadata and extProc filters. It was found that the hard disk is not a bottleneck in this case.

As can be seen in the table, the gateway-proxy CPU is growing very much as a factor of dynamic metadata fields.

image (1)

Expected Behavior

Logging dynamic metadata in accesslogging should not cause substantial processing overhead.

Steps to reproduce the bug

n.a

Additional Environment Detail

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

@DuncanDoyle DuncanDoyle added the Type: Bug Something isn't working label Apr 15, 2024
@htpvu htpvu added the daily-update Issues that require a daily update label Apr 17, 2024
@DuncanDoyle DuncanDoyle changed the title Substantial overhead when loggin Dynamic Metadata in Access Logging Substantial overhead when logging Dynamic Metadata in Access Logging May 8, 2024
@nfuden nfuden self-assigned this May 15, 2024
@htpvu htpvu added the Prioritized Indicating issue prioritized to be worked on in RFE stream label May 15, 2024
@nfuden
Copy link
Contributor

nfuden commented May 17, 2024

Closing for now as a wont do any more on this. Have some collateral in slab for anyone that is interested.

This will also be mitigated once command formatters for typed metadata is added

@nfuden nfuden closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daily-update Issues that require a daily update Prioritized Indicating issue prioritized to be worked on in RFE stream Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants