Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic letters are displayed incorrectly #31

Open
mitryp opened this issue May 25, 2023 · 3 comments
Open

Cyrillic letters are displayed incorrectly #31

mitryp opened this issue May 25, 2023 · 3 comments

Comments

@mitryp
Copy link
Contributor

mitryp commented May 25, 2023

Some characters are not decoded correctly in the mistake suggestions.
The reason is that the language_tool package utilizes the default Response.body getter, which decodes the response in a wrong encoding, while the data is received in the UTF8 encoding.

The screenshot of the incorrect behavior:
image

The screenshot of the expected behavior:
image

The issue makes the usage of the plugin with Cyrillic languages completely impossible, though the API supports them.

@mitryp mitryp changed the title Cyrillic encoding issue Cyrillic letters are displayed incorrectly May 25, 2023
@mitryp
Copy link
Contributor Author

mitryp commented May 25, 2023

The fix for this problem is a one-liner, but the issue is located in the language_tool code :[

@Semsem-programmer
Copy link
Contributor

You can read this:

Arabic decode

Maybe it is useful for you.

@mitryp
Copy link
Contributor Author

mitryp commented Jan 29, 2024

You can read this:

Arabic decode

Maybe it is useful for you.

Thanks, mate!

The original problem in the library this package was using back then was fixed in this PR, in the same way you proposed in the linked issue - great job 🙌
However, this package does not use the API from that lib anymore, so the issue persists here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants