Skip to content
This repository has been archived by the owner on Jun 7, 2018. It is now read-only.

Add new events on_map_finished and on_opening_transition_finished #1191

Open
7 tasks
Diarandor opened this issue May 19, 2018 · 2 comments
Open
7 tasks

Add new events on_map_finished and on_opening_transition_finished #1191

Diarandor opened this issue May 19, 2018 · 2 comments

Comments

@Diarandor
Copy link
Contributor

Diarandor commented May 19, 2018

Add missing transition events to make our lives easier:

Item events:

  • item:on_map_finished(map)
  • item:on_opening_transition_finished(map, destination)

Menu events:

  • menu:on_map_finished(map)
  • menu:on_map_changed(map)
  • menu:on_opening_transition_finished(destination, map)

Game events:

  • game:on_map_finished(map)
  • game:on_opening_transition_finished(map, destination)
@Diarandor
Copy link
Contributor Author

Diarandor commented May 19, 2018

I'd like to use "item:on_map_finished(map)" for some items like the custom shield, to destroy the custom entity shield before the opening transition starts, because the shield remains visible in the original map during this transition (which is bad). I know there are dirtier workarounds like registering this with the multi_events script, but I'd prefer to use a cleaner solution with a normal event. These events are gonna be very useful for other items too.

@Diarandor
Copy link
Contributor Author

This issue can wait for v1.7 since we will be using the multi_event script when necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant