Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This project is working but seems outdated. Which fork to use? #251

Open
donni106 opened this issue Jun 9, 2020 · 26 comments
Open

This project is working but seems outdated. Which fork to use? #251

donni106 opened this issue Jun 9, 2020 · 26 comments

Comments

@donni106
Copy link

donni106 commented Jun 9, 2020

I found different forks in the issues here and I ask myself, which one to use. All seems to have implemented the FlatList instead of ListView to address certain problems.

  1. @riyga25 https://github.com/riyga25/react-native-modal-dropdown
  2. @marshallshen https://github.com/BuildU/react-native-modal-dropdown
  3. @siemiatj https://github.com/siemiatj/react-native-modal-dropdown

3 seems to be mostly updated. 2 seems to be more up to date than 1.
From this point of view, I would go with @siemiatj's version?

There is an open issue, created one month ago: #247 Is this a blocker?

@siemiatj
Copy link

siemiatj commented Jun 9, 2020

Looks like it. Will fix it later today.

@nelsonprsousa
Copy link

@siemiatj Perhaps it's better to create a new repo and not a fork, since it's not possible to open issues there.

Also, I am not able to run the example. Is it possible to upgrade the example to 0.62.2?

@Bilal-Abdeen
Copy link

@donni106 Thanks for the list.
@siemiatj Thanks for this version. It works.

Everyone, I being a newbie, it wasn't easy for me to install a PR. This is how to install @siemiatj's version:
npm install --save https://github.com/siemiatj/react-native-modal-dropdown

@siemiatj
Copy link

@siemiatj Perhaps it's better to create a new repo and not a fork, since it's not possible to open issues there.

Also, I am not able to run the example. Is it possible to upgrade the example to 0.62.2?

Created a clone repo (same url) and will use that from now on.

@donni106
Copy link
Author

Thanks @siemiatj. And you kept the old fork for history here: https://github.com/siemiatj/react-native-modal-dropdown-legacy

I will create an issue in the new one.

@donni106
Copy link
Author

We should change the conencted repository on npm packages to @siemiatj's one.
It would be easier to install and other people will find the updated repository faster.
Has anybody expericence with npm registry? Is this even possible to contact them to change a package repository?
Current here: https://www.npmjs.com/package/react-native-modal-dropdown

@kub1x
Copy link

kub1x commented Jun 30, 2020

We should change the conencted repository on npm packages to @siemiatj's one.
It would be easier to install and other people will find the updated repository faster.
Has anybody expericence with npm registry? Is this even possible to contact them to change a package repository?
Current here: https://www.npmjs.com/package/react-native-modal-dropdown

I believe repository is simply taken from repository field of package.json once you npm publish it. Also there can't be two packages of the same name. I thing what you're asking for is @sohobloo to either remove the package from npm (so it can be published by @siemiatj), or somehow hand it over. Or @siemiatj can rename it, making it effectively a new npm package.

Edit: Found more on taking over packages here: https://wlach.github.io/blog/2017/07/taking-over-an-npm-package-sanity-prevails/ it might be a matter of one email.

@siemiatj
Copy link

I think it'd be easiest to just create a new npm package as @sohobloo seems to have abandoned this ship. But I'll try to reach out to both him and npm first.

@Amol-B-Patil
Copy link

@Bilal-Abdeen Thanks a lot for suggestion. It works!
@siemiatj Thanks a lot for this version. Please maintain this version.

I added it in my project and it works! Thanks a lot!

@SrBrahma
Copy link

Thanks, @siemiatj . If you can't update this package by contacting npm, you really should upload your version as a new package.

@djpetenice
Copy link

djpetenice commented Aug 4, 2020

I've just upgraded my app to RN 0.63.2 and added the @siemiatj version - all works apart from nothing happens when I select a row - any ideas what's causing that?

@ngsayjoe
Copy link

ngsayjoe commented Aug 4, 2020

@siemiatj Updating the dropdown options dynamically shows loading icon instead of the updated options.

@olehk-srs
Copy link

I've just upgraded my app to RN 0.63.2 and added the @siemiatj version - all works apart from nothing happens when I select a row - any ideas what's causing that?

Had the same problem.

I removed TouchableOpacity that was wrapping my component passed to renderRow prop.

@Kishanjvaghela
Copy link

Kishanjvaghela commented Oct 26, 2020

Try this, added support for right component / dropdown icon and full width
https://github.com/Kishanjvaghela/react-native-modal-dropdown

@donni106
Copy link
Author

@Kishanjvaghela do you want to provide your new features as PR to https://github.com/siemiatj/react-native-modal-dropdown?

@kub1x
Copy link

kub1x commented Oct 27, 2020

@siemiatj any news about the npm package? It feels like it's time to move on. Not trying to push, just showing interest for this thing to be sorted out.

@tim92109
Copy link

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

@tim92109
Copy link

Please update the following components: %s, ModalDropdown

@kub1x
Copy link

kub1x commented Nov 16, 2020

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
Please update the following components: %s, ModalDropdown

@tim92109 Please read the comments (or the topic of the discussion you are posting to) first. This project is outdated. Most actively maintained fork can be found here: https://github.com/siemiatj/react-native-modal-dropdown

@tim92109
Copy link

@kub1x ok thx

@siemiatj
Copy link

Just wanted to let you know that I successfully took over the npm package and published a new version under the same name.

@tim92109
Copy link

Awesome @siemiatj ! Stoked to use it again

@ghetinavlad
Copy link

Hello guys, is there any way I can know which option is selected at a given moment ? I've been struggling , haven't figured it out yet

@donni106
Copy link
Author

Hello guys, is there any way I can know which option is selected at a given moment ? I've been struggling , haven't figured it out yet

You can use the onSelect prop and pass a method, for example a setter for a state variable, that you can use elsewhere. Please have a look at the examples, where you can find usages in dropdown_4, dropdown_5 and dropdown_6. Hope that helps.

@ghetinavlad
Copy link

Hello guys, is there any way I can know which option is selected at a given moment ? I've been struggling , haven't figured it out yet

You can use the onSelect prop and pass a method, for example a setter for a state variable, that you can use elsewhere. Please have a look at the examples, where you can find usages in dropdown_4, dropdown_5 and dropdown_6. Hope that helps.

Thanks for the help, got it.

@HoangHieuHBR
Copy link

HoangHieuHBR commented Dec 22, 2023

Anyone here now ? Why I can't add Icon into input field in spite of I have used renderRightComponent like this
image

Can anyone help me to solve this problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests