Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update.sh installs dev dependencies during the deployment #1470

Open
chr1shaefn3r opened this issue Apr 6, 2022 · 1 comment
Open

update.sh installs dev dependencies during the deployment #1470

chr1shaefn3r opened this issue Apr 6, 2022 · 1 comment
Assignees
@chr1shaefn3r

Comments

@chr1shaefn3r
Copy link
Member

update.sh executes npm ci and therefore installs all dependencies including the dev dependencies, which are not needed (hopefully) in the production deployment.
Suggestion would be to use npm ci --production to preven this.
@leider
Copy link
Contributor

leider commented Apr 6, 2022

What is the benefit-cost ratio? 😀

Seriously: sounds sensible. Maybe you can give it a try locally and report your findings?

@leider leider assigned chr1shaefn3r and unassigned leider Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chr1shaefn3r chr1shaefn3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leider @chr1shaefn3r