Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: A number in the column name generates an error log #1992

Open
jochenchrist opened this issue Jan 20, 2024 · 3 comments
Open

Bug: A number in the column name generates an error log #1992

jochenchrist opened this issue Jan 20, 2024 · 3 comments

Comments

@jochenchrist
Copy link

soda-core 3.1.3

When a missing_count column name contains a number, then soda-core generates an error log.

Example:

SodaCL:

- missing_count(1_Merkmal_Code) = 0:
    name: Check that required field 1_Merkmal_Code has no null values

Generates this error log:

Invalid check "missing_count(1_Merkmal_Code) = 0": extraneous input '_Merkmal_Code' expecting {')', ','}
@tools-soda
Copy link

SAS-2740

@dirkgroenen
Copy link
Contributor

dirkgroenen commented Jan 22, 2024

Hi @jochenchrist, thanks for your feedback. A [temp] fix, for now, might be to wrap the column with quotes, like: missing_count("1_Merkmal_Code"). Would you mind giving that a try whilst we further look into this issue?

@jochenchrist
Copy link
Author

Hi @dirkgroenen, thanks, yes, the workaround works.

mgrig pushed a commit to datacontract/datacontract-cli that referenced this issue Feb 6, 2024
…ult app)

- removed quotes around {field_name} as they are incompatible with BigQuery (thrown error: Cannot GROUP BY literal values). The quotes were originally added as a workaround for sodadata/soda-core#1992, which is solved in the current version of Soda Core v3.1.5
mgrig pushed a commit to datacontract/datacontract-cli that referenced this issue Feb 7, 2024
…ult app)

- removed quotes around {field_name} as they are incompatible with BigQuery (thrown error: Cannot GROUP BY literal values). The quotes were originally added as a workaround for sodadata/soda-core#1992, which is solved in the current version of Soda Core v3.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants