Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange or feed specific methods should not be in base #36

Open
barrysteyn opened this issue Oct 23, 2017 · 2 comments
Open

Exchange or feed specific methods should not be in base #36

barrysteyn opened this issue Oct 23, 2017 · 2 comments

Comments

@barrysteyn
Copy link
Contributor

A good example is CryptoCompare - it has many methods that are specific to itself (for example, get_historical_hour or get_info. The latter is surprising, but I could not find it on brave new coin.

What we need to do is discuss what specific methods we need (see #35) and move those to the base.

For methods specific, we should add the feed/exchange name as a prefix. For example, cryptocompare_get_info. The trick would come in when we want to run this on the cli. So running coin -f cryptocompare info would run cryptocompare_get_info, and coin -f bravenewcoin xyz would run bravenewcoin_get_xyz

@snth
Copy link
Owner

snth commented Oct 23, 2017

I agree with you. We should factor this out into two separate classes, one a low-level ApiClient and the other the higher level DataFeed.

@barrysteyn
Copy link
Contributor Author

Yes, that would work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants