Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Site Visibility window not showing scrollbars if there is more monitoring servers than fit current window #1330

Open
vesajylha opened this issue Jan 8, 2024 · 8 comments

Comments

@vesajylha
Copy link

Describe the bug
Toggle Site Visibility window not showing scrollbars if there is more monitoring servers than fit window when thruk.conf sitepanel=auto is selected.

Thruk Version
3.10

To Reproduce
Steps to reproduce the behavior:

  1. Click on 'xx Up / xx Disabled / xx Down' button
  2. 'Toggle Site Visibility' window doesnt' show scrollbars if there is more servers than fit window.

Expected behavior
Toggle Site Visibility window should show scrollbars when needed if sitepanel=auto setting is enabled.

@sni
Copy link
Owner

sni commented Jan 8, 2024

could you add a screenshot to get an idea of what is wrong?

@teanva
Copy link

teanva commented Apr 16, 2024

Thruk v3.14.2:

sitepanel=tree

SitePanelTree

@sni
Copy link
Owner

sni commented Apr 16, 2024

i see. Do you want to have them like that? Otherwise you could group these backends into sections which would make the list more organized.

@teanva
Copy link

teanva commented Apr 17, 2024

Seems that sections would not help in our case. If tree sitepanel is used then scrollbars would be needed to be able to see all backends.

Section

@sni
Copy link
Owner

sni commented Apr 18, 2024

it's hard to figure out what you are doing based on these mostly black screenscrots. I've seen
installations with over 300 connected backends without issues.
What i mean when i say use sections, is to create multi-level groups of backends, ex.:
section europe/germany would create a top level collapsable folder europe with a sub folder germany. That way you would not have to scroll that much. The other advantage is you can toggle and select backends based on their section all at once.

@teanva
Copy link

teanva commented Apr 18, 2024

In our case it is a bit challenging to divide backends to multi-level sections.

Anyway, point in previous comment was that scroll bars would be helpful also with sections since limited amount of top level sections fit to window.

Section2

@sni
Copy link
Owner

sni commented Apr 18, 2024

i see. Sure scrollbars should help here. A side note, those screenshots show the "collapsed" sitepanel, not the tree site panel.
The tree sitepanel (with sections) looks like this:
Screenshot 2024-04-18 at 11 10 07

@teanva
Copy link

teanva commented Apr 18, 2024

Yes, you are right. Different machine and I forgot to check the sitepanel configuration.

I think that we can fit top level sections to window with tree site panel setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants