Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPMDeviceAttributes.FirmwareVersion should be uint64 #6

Closed
chrisccoulson opened this issue Feb 13, 2020 · 1 comment
Closed

TPMDeviceAttributes.FirmwareVersion should be uint64 #6

chrisccoulson opened this issue Feb 13, 2020 · 1 comment

Comments

@chrisccoulson
Copy link
Collaborator

Although the format of the firmware version is manufacturer specific, it is represented in the TPM as a uint64. The parseTPMDeviceAttributesFromDirectoryName() function in tpm.go extracts the firmware version from the EK certificate, but currently interprets this as a uint32, which isn't correct.
@chrisccoulson
Copy link
Collaborator Author

Closing this given that this code is being removed in #273

@chrisccoulson chrisccoulson closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisccoulson