Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report - [X]cpp example #315

Open
shine-xia opened this issue Apr 3, 2023 · 3 comments
Open

Bug report - [X]cpp example #315

shine-xia opened this issue Apr 3, 2023 · 3 comments
Assignees
@snakers4
Labels
bug Something isn't working examples Community provided examples and connectors help wanted Extra attention is needed

Comments

@shine-xia
Copy link

in file examples/cpp/silero-vad-onnx.cpp, line 124
Do you mean "if (temp_end == 0)" ?
Otherwise temp_end will never get non-zero values
@shine-xia shine-xia added the bug Something isn't working label Apr 3, 2023
@snakers4
Copy link
Owner

snakers4 commented Apr 3, 2023

@pengzhendong

@pengzhendong
Copy link
Contributor

@summer-wing I think you are right. You can fix it.

@yuGAN6
Copy link
Contributor

yuGAN6 commented Apr 5, 2023

Thanks for the report! You are right on that.
It should be if (temp_end == 0) correspond to line 506 if not self.temp_end in utils_vad.py. You can create a pull request to fix.

@snakers4 snakers4 added help wanted Extra attention is needed examples Community provided examples and connectors labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snakers4 snakers4

Labels
bug Something isn't working examples Community provided examples and connectors help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shine-xia @pengzhendong @snakers4 @yuGAN6