Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"createIndex" flag throws error #44

Open
Daveawb opened this issue Sep 17, 2020 · 5 comments
Open

"createIndex" flag throws error #44

Daveawb opened this issue Sep 17, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Daveawb
Copy link
Collaborator

Daveawb commented Sep 17, 2020

The createIndex flag does not function properly.

No components are created if the folder structures requested don't exist. If the folder structures do exist and empty index file is created but no components are created.

@Daveawb Daveawb added the bug Something isn't working label Sep 17, 2020
@PQTran
Copy link
Contributor

PQTran commented Dec 4, 2020

Hi @Daveawb , I'm wondering how can I reproduce your problem? I'm a bit interested in this bug

@snaerth
Copy link
Owner

snaerth commented Dec 7, 2020

@Daveawb @PQTran thanks for taking interest in this. It is a little long since I created this. But if I remember correctly createIndex is only suppose to read components from the current folder and create an index file exporting those components. So not create components. Unless I am misunderstanding the main issue

@Daveawb
Copy link
Collaborator Author

Daveawb commented Feb 5, 2021

@snaerth and @PQTran I believe this was introduced when I wrote the template code. It's been a while since I looked at this issue, I'll try and reproduce again and provide steps.

@snaerth
Copy link
Owner

snaerth commented Feb 5, 2021

Awesome thanks @Daveawb

@Daveawb
Copy link
Collaborator Author

Daveawb commented Feb 9, 2021

So here's how I reproduced it.

image

However without --createindex

image

Note that Test does not exist at the time of creating the component.

I understand that the original intention was not to create any components but in this case specifically, we're creating a component AND creating an index of all components. This probably should either be fixed to allow component creation and a base index, or documented. Alternatively a separate command for indexing might be clearer that doesn't accept any arguments so that you can't mix the two up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants