Unable to deploy on ServiceMix 7.0.0

[blackard]

I've been playing with Smooks but ran into a problem deploying on ServiceMix 7.0.0 using the features.xml file for 1.7.0, which I need to use due to #94.

The issue seems to be around Groovy 1.8.8. When that bundle tries to install on the Karaf Console I get:

karaf@root>feature:repo-add mvn:org.milyn/milyn-smooks-all/1.7.0/xml/features
Adding feature url mvn:org.milyn/milyn-smooks-all/1.7.0/xml/features
karaf@root>feature:install smooks
Error executing command: Error
karaf@root>

Excerpts from the log show Felix is throwing an IllegalArgumentException:

2017-08-24 09:23:38,259 | ERROR | nsole user karaf | ShellUtil                        | 136 - org.apache.karaf.shell.core - 4.0.8 | Exception caught while executing command
org.apache.karaf.features.internal.util.MultiException: Error
	at org.apache.karaf.features.internal.download.impl.MavenDownloadManager$MavenDownloader.<init>(MavenDownloadManager.java:84)[8:org.apache.karaf.features.core:4.0.8]
	... c
Caused by: java.lang.Exception: Unable to create resource for bundle mvn:org.codehaus.groovy/com.springsource.org.codehaus.groovy/1.8.8
	at org.apache.karaf.features.internal.region.Subsystem.createResource(Subsystem.java:605)[8:org.apache.karaf.features.core:4.0.8]
	... 
Caused by: org.osgi.framework.BundleException: Unable to build resource for mvn:org.codehaus.groovy/com.springsource.org.codehaus.groovy/1.8.8: invalid version range: [1.0.0,1.0.0)
	at org.apache.karaf.features.internal.resolver.ResourceBuilder.build(ResourceBuilder.java:80)[8:org.apache.karaf.features.core:4.0.8]
	...
Caused by: java.lang.IllegalArgumentException: invalid version range: [1.0.0,1.0.0)
	at org.apache.felix.utils.version.VersionRange.checkRange(VersionRange.java:346)[8:org.apache.karaf.features.core:4.0.8]
	...

I was able to work around the issue by not using the Smooks features file and installing alternative versions and bundles as follows:

feature:install camel-groovy
install -s mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.antlr/3.5.2_1
install -s mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.freemarker/2.3.21_1
install -s mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jaxen/1.1.3_1
install -s mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.asm/3.3.1_1
install -s mvn:org.ow2.bundles/ow2-bundles-externals-opencsv/1.0.36
install -s mvn:org.milyn/milyn-smooks-all/1.7.0

The camel-groovy feature is bringing in a much newer version of CodeHaus Groovy (2.4.5) and it seems to be working just fine. This is the one aspect of the work around that bothers me a little, but it keeps things consistent with Camel/ServiceMix. There isn't a newer org.codehaus.groovy/com.springsource.org.codehaus.groovy version to select. As an alternative I tested with mvn:org.codehaus.groovy/groovy-all/1.8.9 and that seemed to work as well, but due to the presence of Camel in ServiceMix, I'm going to stick with that feature.