Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No uses of @ReportPolymorphism? #311

Open
fniephaus opened this issue Aug 7, 2019 · 2 comments
Open

No uses of @ReportPolymorphism? #311

fniephaus opened this issue Aug 7, 2019 · 2 comments
Labels
enhancement Improves the implementation with something noteworthy good first issue Are you trying to have a good at SOMns? Start here! help wanted Would be great if you could help out here.

Comments

@fniephaus
Copy link
Contributor

Hi @smarr,

I'm wondering why none of SOMns' nodes are annotated with @ReportPolymorphism. Maybe time to look into ReportingPolymorphism.md?

Fabio

@smarr
Copy link
Owner

smarr commented Aug 7, 2019

The answer is unfortunately, because it's "new", and because noone has spent time on it so far.
But, yes, would probably good to use it.

@smarr smarr added this to Open Issues in Completeness via automation Aug 7, 2019
@smarr smarr added enhancement Improves the implementation with something noteworthy good first issue Are you trying to have a good at SOMns? Start here! help wanted Would be great if you could help out here. labels Aug 7, 2019
@smarr
Copy link
Owner

smarr commented Aug 7, 2019

There are some uses of getCost(), and any work on using @ReportPolymorphism should investigate how to reconcile those two things.

Example:

@Override
public NodeCost getCost() {
return Cost.getCost(dispatchNode);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the implementation with something noteworthy good first issue Are you trying to have a good at SOMns? Start here! help wanted Would be great if you could help out here.
Projects
No open projects
Completeness
  
Open Issues
Development

No branches or pull requests

2 participants