Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release: fix discrepancy between pypi, release, and git #39

Open
bernt-matthias opened this issue Jun 3, 2021 · 2 comments
Open

Comments

@bernt-matthias
Copy link

I'm currently trying to fix the bioconda recipe for plasflow: bioconda/bioconda-recipes#27766

I noticed that the content of the download available at pypi and the release on github seems to differ. In particular the model dir seems missing in the pypi release.

I guess its because in setup.py

package_data={'models': ['models/*']},

should be

package_data={'plasflow': ['models/*']},

It would be great if you could create a new release fixing this.

@smaegol
Copy link
Owner

smaegol commented Jun 28, 2021

I reverted to the latest stable release. I hope it is fixed now.

Unfortunately, I moved to completely other field, thus my time for this project is seriously limited.

smaegol added a commit that referenced this issue Jun 28, 2021
FIx for issue #39
@smaegol
Copy link
Owner

smaegol commented Jun 28, 2021

I think that bioconda recipe cannot be fixed, as they clearly state that if this only works ith Py3.5 they cannot support it (https://github.com/bioconda/bioconda-recipes/blob/master/recipes/plasflow/meta.yaml#L22). As I mentioned, I reverted back to previous, stable, working release (the same as in pypi); I thought that more package-like structure proposed by @dcdanko will be better, but I haven't tested it thoroughly before merging pull request, my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants