Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supply-chain-threats.svg to reflect current 1.0 scope #1004

Open
cqueern opened this issue Nov 30, 2023 · 2 comments
Open

Update supply-chain-threats.svg to reflect current 1.0 scope #1004

cqueern opened this issue Nov 30, 2023 · 2 comments
Labels
clarification Clarification of the spec, without changing meaning

Comments

@cqueern
Copy link

cqueern commented Nov 30, 2023

Hi, with Source being temporarily out of scope for SLSA in 1.0, would like to request that maintainers consider updating this image to reflect that Source Threats are not addressed in current SLSA scope.

docs/images/supply-chain-threats.svg

A casual observer skimming the documentation but not reading everything may misunderstand that SLSA currently addresses Source Threats A-C without such an update. Options might include greying out Source Threats A-C or removing them until they're in scope again someday.

@MarkLodato
@devmoran

@lehors
Copy link
Member

lehors commented Nov 30, 2023

Thanks for the feedback.

The graphic is really focused on threats and not what SLSA currently covers so I don't know that we should necessarily change the graphic itself but I think we could add a note next to it to point out that not all these threats are currently addressed by SLSA or even states that SLSA 1.0 focuses on Build threats.

In addition, looking at the rest of the page I think there are several sections that can be misleading and would benefit some clarification, such as "Source integrity: [...] SLSA approximates this as approval from two authorized representatives." or the "How SLSA can help" column. It sure "can" but does not yet...

lehors added a commit to lehors/slsa that referenced this issue Nov 30, 2023
This addresses issue slsa-framework#1004.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
@lehors lehors added the clarification Clarification of the spec, without changing meaning label Nov 30, 2023
@MarkLodato
Copy link
Member

It might also help to show how each level applies to each threat. Something like supply-chain-threats-build-verification.svg but per-level. I tried and failed doing this in the past, but maybe we should try again.

joshuagl pushed a commit that referenced this issue Jan 8, 2024
…#1005)

This addresses issue #1004.

---------

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Co-authored-by: Mark Lodato <lodatom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Clarification of the spec, without changing meaning
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants