Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Regenerate multiple subject tests that use builders@main #639

Open
asraa opened this issue Jun 8, 2023 · 0 comments
Open

[test] Regenerate multiple subject tests that use builders@main #639

asraa opened this issue Jun 8, 2023 · 0 comments
Labels
area:tests Issue with unit tests

Comments

@asraa
Copy link
Contributor

asraa commented Jun 8, 2023

I noticed the CLI test uses builders at main for the multiple subject tests. This means we can't remove SLSA_VERIFIER_TESTING that was enabled in the CI tests for the unrelease container-based builder, but confounded due to parallelized testing with the use of builders at main for multiple subjects.
@ianlewis ianlewis added the area:tests Issue with unit tests label Jun 16, 2023
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@naveensrinivasan @ianlewis
Included typescript-eslint (slsa-framework#639)
82a95be 
- Included typescript-eslint
- This is based on https://github.com/actions/typescript-action
- Fixes slsa-framework#610

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

Co-authored-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:tests Issue with unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianlewis @asraa