Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyIsLike implementation #280

Open
rghosh0 opened this issue Feb 8, 2017 · 2 comments
Open

PropertyIsLike implementation #280

rghosh0 opened this issue Feb 8, 2017 · 2 comments

Comments

@rghosh0
Copy link

rghosh0 commented Feb 8, 2017

I have a question about whether the wildCard, singleChar, and escapeChar attributes of PropertyIsLike should be restricted to single character strings.

The schema (http://schemas.opengis.net/filter/1.1.0/filter.xsd) doesn't make any such restriction, and the Implementation Spec doesn't mention PropertyIsLike.

However, the following sources seem to assume a single character restriction:

http://docs.geotools.org/latest/javadocs/org/opengis/filter/PropertyIsLike.html

The pattern is defined by a combination of regular characters, the wildCard character, the singleChar character, and the escape character.

http://docs.geoserver.org/latest/en/user/filter/filter_reference.html

wildCard specifies the pattern character which matches any sequence of zero or more string characters
singleChar specifies the pattern character which matches any single string character
escapeChar specifies the escape character which can be used to escape the pattern characters

I realize that the user can choose to use a single character. But I wonder if there is value in restricting these attributes to a single character, to prevent incompatibility between the SLD document and systems that use SLD (to prevent the creation of a SCISYS-only SLD document)

@sldeditor
Copy link
Owner

It's a bit of tricky one in that the GUI only reflects what GeoTools tells it, and unfortunately it defines the single character as a string. I'll have look to see if I can intercept it and restrict to a single character.

@sldeditor
Copy link
Owner

Closed by pull request #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants