Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Response instead of BaseResponse #68

Open
3 tasks done
WilliamBergamin opened this issue Apr 17, 2023 · 0 comments
Open
3 tasks done

Return Response instead of BaseResponse #68

WilliamBergamin opened this issue Apr 17, 2023 · 0 comments
Labels
enhancement New feature or request major This PR requires a major version bump

Comments

@WilliamBergamin
Copy link
Contributor

Description

Currently the base BaseSlackClient defines the return type of apiCall and response as Promise<BaseResponse> which represents the json payload returned by the Slack API.

This is an issue since users may want to access more then just the json payload from the Response such as headers and status codes.

In the next major release apiCall and response should return some version of Promise<[Response](https://deno.com/deploy/docs/runtime-response)> instead. It will be a breaking change.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@WilliamBergamin WilliamBergamin added enhancement New feature or request major This PR requires a major version bump labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major This PR requires a major version bump
Projects
None yet
Development

No branches or pull requests

1 participant