Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack::Event::Request#verify! should use secure_compare #512

Open
mintuhouse opened this issue Mar 27, 2024 · 1 comment
Open

Slack::Event::Request#verify! should use secure_compare #512

mintuhouse opened this issue Mar 27, 2024 · 1 comment
Labels
new feature

Comments

@mintuhouse
Copy link

slack-ruby-client/lib/slack/events/request.rb

Line 62 in 9e6d117

computed_signature == signature

if using active_support something like ActiveSupport::SecurityUtils.secure_compare
@dblock
Copy link
Collaborator

dblock commented Mar 27, 2024

Good point, want to PR something along those lines @mintuhouse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @mintuhouse