Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionSheetStringPicker Popover Toolbar Cutoff for iOS 13 on iPads #470

Open
herrchmafi opened this issue Feb 13, 2020 · 5 comments
Open

Comments

@herrchmafi
Copy link

The UIToolbar (in AbstractActionSheetPicker) gets cut off at the top for iOS 13 on iPads. Looking at the view hierarchy, it looks like the parent view placement isn't inset properly (should be positioned under caret).

@skywinder
Thank you for your work!

@pkccsb
Copy link

pkccsb commented Apr 9, 2020

Any update on this ticket?

@skywinder
Copy link
Owner

no, didn't check it

@skywinder
Copy link
Owner

If anyone knows how to reproduce and fix it - please, let me know

@Algalish
Copy link

@skywinder As far as I know - popovers are deprecated in iOS 9 and later.
Your library is not working anymore on iPad for me so I went to AbstractActionSheetPicker.m file and changed the return for function "canShowPopover" to "NO" like that
+ (BOOL)canShowPopover { return NO; }

Since nobody uses iOS 9 or earlyer versions - I think it is safe to do it like this without conditions for the iOS version.

@noorulain17
Copy link
Collaborator

noorulain17 commented Nov 11, 2020

@herrchmafi iOS 9 support has been dropped from ActionSheetPicker-3.0 -> 2.6.1 version.
Please update the library to the latest version and let us know if the above issue still exists or not.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants