Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Upgrade to clap 4.0 or 3.0 #283

Open
3 of 4 tasks
ohsayan opened this issue Sep 30, 2022 · 3 comments
Open
3 of 4 tasks

Internal: Upgrade to clap 4.0 or 3.0 #283

ohsayan opened this issue Sep 30, 2022 · 3 comments
Labels
C-dependencies Pull requests that update a dependency file C-enhancement New feature or request L-Easy Good for newcomers

Comments

@ohsayan
Copy link
Member

ohsayan commented Sep 30, 2022 •
edited

We're still on the 2.x release of clap, and the current major version of clap is 4.0. The reason we skipped the 3.0 update was because support for yaml files was removed in favor of a derive-based API. Although this is trivial to rewrite in the case of the other binaries, it isn't an entirely simple task in the case of the skyd binary because the config module relied on a lot of machinery that clap 2.x supported. Although I believe I did raise this with clap's team and they rolled out a release with support for the library fns that we needed, we haven't had a chance to upgrade since then. If someone wants to help upgrade the code, I'll be happy to mentor, else I'll do it later when I have the time.

Progress on upgrades:
@ohsayan ohsayan added C-enhancement New feature or request C-dependencies Pull requests that update a dependency file L-Easy Good for newcomers labels Sep 30, 2022
@sanjayts
Copy link
Contributor

Hey @ohsayan , happy to lend a hand with this one - Discord a good place to talk about this?

@ohsayan
Copy link
Member Author

ohsayan commented Oct 18, 2022

Hey @ohsayan , happy to lend a hand with this one - Discord a good place to talk about this?

Please drop by Discord and we can discuss this. Thanks!

@sanjayts sanjayts mentioned this issue Oct 23, 2022
Merged
@ohsayan
Copy link
Member Author

ohsayan commented Oct 25, 2022

@sanjayts Has has been working on this across #284, #285 and #286 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-dependencies Pull requests that update a dependency file C-enhancement New feature or request L-Easy Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanjayts @ohsayan