Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-typical "Fingerprint" language used in Page Information #645

Open
acidus99 opened this issue Dec 28, 2023 · 2 comments
Open

Non-typical "Fingerprint" language used in Page Information #645

acidus99 opened this issue Dec 28, 2023 · 2 comments
Labels
enhancement New feature or request pending release Issue has been resolved and the fix/feature will be included in an upcoming release.

Comments

@acidus99
Copy link

Lagrange currently has a "Copy Fingerprint" button under a "Certificate" section of the "Page Information" model. Lagrange uses this to mean the SHA-256 hash of just the bytes of the public key, contained inside the certificate.

This is very confusing because that is not the typical definition of the term "Fingerprint", when used in the context of X.509 certificates. The overwhelming majority of software that handles or displays certificates use the "fingerprint" terminology to mean "a hash of the entire certificate." Examples of software that use this typical definition are:

  • macOS (in all OS-wide certificate controls, Safari, etc.)
  • OpenSSL (via the -fingerprint argument)
  • Firefox (in it's Certificate details view)
  • Windows (in all OS-wide certificate controls, Edge browser, IIS, though it uses "thumbprint" instead of "fingerprint")

Please consider changing Lagrange's terminology to avoid this confusion. A few options:

  • Add a "Public Key" section to the "Page Information" Model that displays the hash function (SHA-256) and value for the public key
  • Change the button text to say "Copy Public Key Fingerprint" or "Copy Public Key SHA-256 Hash"
@skyjake skyjake added the enhancement New feature or request label Jan 12, 2024
@skyjake
Copy link
Owner

skyjake commented Jan 12, 2024

I agree this needs some clarifying.

skyjake added a commit that referenced this issue May 6, 2024
@skyjake
DocumentWidget: Clarify what "fingerprint" means in Page Information
a13b08d 
The UI now allows copying both types of fingerprints: full certificate
or public key.

IssueID #645
@skyjake
Copy link
Owner

skyjake commented May 6, 2024

Implemented for v1.18.

@skyjake skyjake added the pending release Issue has been resolved and the fix/feature will be included in an upcoming release. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pending release Issue has been resolved and the fix/feature will be included in an upcoming release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skyjake @acidus99