Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality tests for dumpreader and SingleSpeciesAnalyzer #28

Open
skuschel opened this issue Jun 1, 2015 · 2 comments
Open

Equality tests for dumpreader and SingleSpeciesAnalyzer #28

skuschel opened this issue Jun 1, 2015 · 2 comments
Labels
enhancement needs discussion particles

Comments

@skuschel
Copy link
Owner

skuschel commented Jun 1, 2015

Implement Equality tests for dumpreader and SingleSpeciesAnalyzer. This allows that ParticleAnalyzer can be added together without adding Particles twice, in case they overlap. It will also allow to easily check if a particle analyzer contains particles of another.
@skuschel
Copy link
Owner Author

Equality tests for dumpreader have been implemented 341cdae. Its not straigt forward what == should mean for singlespecies or multispecies objects including the option, that the particle lists might be reduced due to compression functions (like taking only particles with gamma > 2 or similar). Concept needed.

@skuschel
Copy link
Owner Author

Regarding #117 it may be useful to define "dr1 == dr2" to be True if they are returning the same particles in the same order (although from a possibly different dump)?

@skuschel skuschel added particles Field core routines affected and removed particles labels Dec 19, 2017
@skuschel skuschel added particles and removed Field core routines affected labels Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs discussion particles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skuschel