Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: pass company code into config #15

Open
skukx opened this issue Feb 10, 2020 · 0 comments
Open

RFC: pass company code into config #15

skukx opened this issue Feb 10, 2020 · 0 comments

Comments

@skukx
Copy link
Owner

skukx commented Feb 10, 2020

There are certain endpoints which company code gets passed as a parameter into the calling function.

Should we instead pass company code into the initialization of the client so that it doesn't need to be passed into other methods.

This makes a subtle change that a single client cannot act on multiple company codes, and a new client would need to be instantiated for each company code.

I somewhat doubt this affects many if any at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant