Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebpWriter multiThread always false? #289

Open
zoff99 opened this issue Apr 24, 2024 · 2 comments
Open

WebpWriter multiThread always false? #289

zoff99 opened this issue Apr 24, 2024 · 2 comments

Comments

@zoff99
Copy link

zoff99 commented Apr 24, 2024

scrimage/scrimage-webp/src/main/java/com/sksamuel/scrimage/webp/WebpWriter.java

Line 70 in 24b63c5

return new WebpWriter(z, q, m, lossless, noAlpha, multiThread);

should that say:

return new WebpWriter(z, q, m, lossless, noAlpha, true);
zoff99 added a commit to zoff99/trifa_material that referenced this issue Apr 24, 2024
@zoff99
enable MultiThread for webp image encoding, it may not work yet: sksa…
77a0141 
…muel/scrimage#289
@sksamuel
Copy link
Owner

Yes. Good catch.

@zoff99
Copy link
Author

zoff99 commented Apr 25, 2024

can you publish a fix release?

zoff99 added a commit to Zoxcore/trifa_material that referenced this issue Apr 26, 2024
@zoff99
enable MultiThread for webp image encoding, it may not work yet: sksa…
0957c28 
…muel/scrimage#289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sksamuel @zoff99