Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use t_max and t_save even when effort array is supplied to project() #231

Open
gustavdelius opened this issue Sep 11, 2021 · 0 comments
Open
Labels
enhancement New feature requests or suggestions for enhancement of existing features low priority

Comments

@gustavdelius
Copy link
Member

gustavdelius commented Sep 11, 2021

An interesting point came up in an example by @juliablanchard which had an effort array with an NA in the effort for the final year.

Currently the t_max argument in project() is ignored when the user supplies an effort array and the final time is taken from the effort array. Instead the final time in the effort array is used to determine the end time of the simulation. This was done originally for backwards compatibility with mizer 0.3. This has the drawback that the user needs to make up values for the effort at the final time, even though that effort will not actually be used during the simulations.

I propose that we change that and use the t_max value when it is supplied to determine how long the simulation should run, even when an effort array is provided. Then for example someone who has effort values until and including 2018 can run the simulation until 2019 by setting t_max = 2019 instead of making up a value for 2019.

Similarly I propose that the t_save argument is used to determine at which times the simulation values are saved, even when an effort array is provided. When t_save is not supplied, we will continue to save at the times specified in the effort array.

So the only argument that will continue to be ignored when an effort array is supplied is t_start.

@gustavdelius gustavdelius changed the title Use t_max even when effort array is supplied to project() Use t_max and t_save even when effort array is supplied to project() Sep 11, 2021
@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features low priority labels Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature requests or suggestions for enhancement of existing features low priority
Projects
None yet
Development

No branches or pull requests

1 participant