Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"googleWebVitals.cumulativeLayoutShift" Shows the summary box metric in blue color even after setting up the thresholds #4119

Open
2343909 opened this issue Mar 26, 2024 · 4 comments

Comments

@2343909
Copy link

2343909 commented Mar 26, 2024

"googleWebVitals.cumulativeLayoutShift" shows the summary box metric in blue color even after setting up the thresholds.

I am trying to set up the limits for it where the "summary box metric" would show in red if over the thresholds. I tried to place the "pageinfo.cumulativeLayoutShift" as a "summary box metric" but I get an error: "Error: pageinfo.cumulativeLayoutShift is not part of summary box metric.".
Placing "googleWebVitals.cumulativeLayoutShift" shows up on the summary page but setting up the thresholds does not do anything and the box stays in blue:
I set it like this:

  googleWebVitals: {
    cumulativeLayoutShift: { green: 0.0, yellow: 0.1 }
  },
@soulgalore
Copy link
Member

Ah thank you @2343909 for creating the issue. Let me have a look. I think CLS should have setting for default values, following Google Web Vitals recommendations.

@2343909
Copy link
Author

2343909 commented Mar 27, 2024

@soulgalore Thank you! Yes, it shows default settings for CLS "pageinfo.cumulativeLayoutShift" (https://github.com/sitespeedio/sitespeed.io/blob/main/lib/plugins/html/setup/summaryBoxesDefaultLimits.js) but that one cannot be put on the "summary box metrics" page and I am not seeing google one.
Again, thanks a lot for looking into this.

image

@2343909
Copy link
Author

2343909 commented Apr 2, 2024

@soulgalore Thanks for taking care of this, it works now. However, all of the axe thresholds do not change colors, they stay in blue even after the thresholds are breached:

axe: {
    critical: { green: 0, yellow: 1 },
    serious: { green: 0, yellow: 1 },
    minor: { green: 0, yellow: 1 },
    moderate: { green: 0, yellow: 1 }
  },

image

soulgalore added a commit that referenced this issue Apr 2, 2024
soulgalore added a commit that referenced this issue Apr 3, 2024
@2343909
Copy link
Author

2343909 commented Apr 3, 2024

@soulgalore It works, thank you very much for a very quick resolution and response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants