New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long URLs being performance tested generate errors #4110
Comments
Hi @2343909 thank you for creating the bug report (and including logs etc). There's been a problem on Windows with long URLs if you haven't enabled long file names but this looks like something else. Can you check which Python version you are using, it seems that 3.12 (HandBrake/HandBrake#5454) maybe introduced this? |
Hi @soulgalore Thanks a lot for quick response and yes, I am using Python 3.12.2 |
Hi @2343909 can you try run just a simple test without a scripting and see if you get the same? I tested on Windows with 3.12 and do not get that error. You can checkout the test with Edge and video: https://github.com/sitespeedio/browsertime/actions/runs/8281202122/job/22659184892 |
Hey @soulgalore, I just tried without scripting with Edge and Chrome, the same error occurs . Looks like you are running it with " node bin/browsertime.js" and I am running it with "node bin/sitespeed.js" |
Yes but sitespeed.io uses browsertime internally. Just wanted to verify, shorter URL works fine for you (just so all dependencies for video recording/analysing is working)? Can you try to remove |
@soulgalore I tried it multiple different ways as you have suggested in the previous comment and the outcome is the same specifically for the long URLs. |
@2343909 ok. Do you have long paths enabled on your machine as in this PR https://github.com/sitespeedio/browsertime/pull/2040/files ? I want to avoid adding that to the code because it seems strange to edit people properties, but you can manually set it if you don't have already? |
@soulgalore Ok, looks like that is what the issue was... I enabled long paths:
|
@soulgalore However :), there is slight small additional issue when selecting the long URL in the HTML report under the "Page" tab where after clicking on the long URL I get no file found error but if I change the name to something shorter then it works fine: Uploading 2024-03-26_14h58_02.mp4… |
Have you read the documentation?
URL
See in the script
What are you trying to accomplish
Here is execution command:
node bin/sitespeed.js -b chrome -n 1 --video --visualMetrics --multi storefront\storefront_fe\src\workflows\demo.mjs
NOTE: If " --visualMetrics" is removed, then it works fine.
What browser did you use?
Chrome
How to reproduce
Log output
The text was updated successfully, but these errors were encountered: