Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] S3 Expire, incorrect description #4077

Open
Amerousful opened this issue Feb 5, 2024 · 1 comment
Open

[Documentation] S3 Expire, incorrect description #4077

Amerousful opened this issue Feb 5, 2024 · 1 comment

Comments

@Amerousful
Copy link
Contributor

Amerousful commented Feb 5, 2024

Feature/improvement

Hello there!
According to the documentation, to set the expiration date for S3, we should set a timestamp after how long files will be deleted, but in fact, this param Expires is about when files will be deleted.
-s3.params.Expires=31536000 to set expire to one year. it sets for AWS S3 Friday, January 1, 1971 00:00:00 GMT
image 1934

Thus, for proper expiration time, we have to do something like this:
-s3.params.Expires=$(($(date +%s) + 31536000))

Links on the documentation where mention it:
https://www.sitespeed.io/documentation/sitespeed.io/s3/#extra-configuration
https://www.sitespeed.io/documentation/sitespeed.io/configuration/

@narasimha-1511
Copy link

i want to work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants