Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I do not think sync_activities is in good shape #64

Open
venkatkondababu opened this issue Mar 20, 2020 · 0 comments
Open

I do not think sync_activities is in good shape #64

venkatkondababu opened this issue Mar 20, 2020 · 0 comments

Comments

@venkatkondababu
Copy link

venkatkondababu commented Mar 20, 2020

sync_activities not updating update_state_with_export_info with export_end time.

state = update_state_with_export_info(state, stream, bookmark=export_start.isoformat())
export_start = export_end
should really be -->
export_start = export_end
state = update_state_with_export_info(state, stream, bookmark=export_start.isoformat())

update_state_with_export_info should take export_end i believe.

If anybody tried sync_activities , i like to hear any comments on your experiences, whether you are able to completely load activities tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant