-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search feature #18
Comments
I've been wondering if a clientside soluton is feasible. Something local to the songs by chorus/first line page that can be filled in. All we really need is the "find in page" functionality that web browsers have (is there a standard way to invoke that?). |
I think the clientside solution would work okay but lacks useful things
like typo correction etc.
I've also been wondering if we're good just to have a Google or DuckDuckGo
site search box on the site instead - do you think anyone would care about
that? DDG hasn't indexed the site yet.
J
…On Sun, 31 Mar 2019, 13:44 Yasha Jannoo, ***@***.***> wrote:
I've been wondering if a clientside soluton is feasible. Something local
to the songs by chorus/first line page that can be filled in. All we really
need is the "find in page" functionality that web browsers have (is there a
standard way to invoke that?).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/At8ga7WAw49boCJEBKXOC7TcbR9ROoh0ks5vcK3AgaJpZM4cEaKD>
.
|
Most handheld devices do typo correction on input, but I imagine you're talking about similar search terms type stuff and I see why that's handy. I don't think people will care, how backend-y will it look? I know I've seen "search provided by google" stamps on embedded search bars and that it takes you to a google results page. DuckDuckGo seems really cool, I'd never heard of it. 🦆 |
For now I've made #27 which you can preview here |
...it's okay, but it |
We should be able to search the songs - don't want to put it in persistent menu bar as that should be straightforwardly for jumping to a song. Possibly at the top of the songs page, and top of the Index page?
It'd be fine to use Google/Bing search or similar if the results are clean. Other options are Algolia or something customs and frobtendy
The text was updated successfully, but these errors were encountered: