Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature #18

Open
singaround opened this issue Mar 22, 2019 · 5 comments
Open

Search feature #18

singaround opened this issue Mar 22, 2019 · 5 comments

Comments

@singaround
Copy link
Owner

We should be able to search the songs - don't want to put it in persistent menu bar as that should be straightforwardly for jumping to a song. Possibly at the top of the songs page, and top of the Index page?

It'd be fine to use Google/Bing search or similar if the results are clean. Other options are Algolia or something customs and frobtendy

@RogerioY
Copy link
Collaborator

I've been wondering if a clientside soluton is feasible. Something local to the songs by chorus/first line page that can be filled in. All we really need is the "find in page" functionality that web browsers have (is there a standard way to invoke that?).

@singaround
Copy link
Owner Author

singaround commented Mar 31, 2019 via email

@RogerioY
Copy link
Collaborator

RogerioY commented Apr 4, 2019

Most handheld devices do typo correction on input, but I imagine you're talking about similar search terms type stuff and I see why that's handy.

I don't think people will care, how backend-y will it look? I know I've seen "search provided by google" stamps on embedded search bars and that it takes you to a google results page.

DuckDuckGo seems really cool, I'd never heard of it. 🦆

@singaround
Copy link
Owner Author

For now I've made #27 which you can preview here

https://deploy-preview-27--auntieshanty.netlify.com/songs/

@singaround
Copy link
Owner Author

...it's okay, but it
(a) doesn't deal well with similar words like I'd hoped (no hits for 'fire maringo' for example, despite "fire marengo" being fine. I think I might need to play a bit more with the settings for the Google Custom Search though
(b) it'll turn up songs that are in the unfiltered songs list, I think, as they all live in the same namespace. If we go with this approach, I can probably fix that somehow by filtering on some page properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants