Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error and completed events not emitted on v6 #179

Open
0xOlias opened this issue Mar 14, 2023 · 3 comments
Open

error and completed events not emitted on v6 #179

0xOlias opened this issue Mar 14, 2023 · 3 comments

Comments

@0xOlias
Copy link

0xOlias commented Mar 14, 2023

The docs mention error and completed events, but these are not being emitted on v6. I suspect that this is the root cause of a number of open issues (#171, #169).

I would take a stab at a PR to add them, but I'm not sure how the release process works for v6.

@sindresorhus
Copy link
Owner

v6 is no longer supported. Are these issues reproducible on v7?

@0xOlias
Copy link
Author

0xOlias commented Mar 14, 2023

I'm not sure. I didn't realize v6 was unsupported, that's unfortunate. Feel free to close.

@darky
Copy link

darky commented Apr 4, 2023

Would be better to support v6 too, seems very hard to shift community from cjs -> esm

Screenshot 2023-04-04 at 15 59 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants