Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible and hidden OpenBikeSensor readings #72

Open
selphiron opened this issue Nov 7, 2022 · 5 comments
Open

Visible and hidden OpenBikeSensor readings #72

selphiron opened this issue Nov 7, 2022 · 5 comments
Assignees

Comments

@selphiron
Copy link
Contributor

When a user presses the hardware button of the OpenBikeSensor connected to the SimRa App via Bluetooth, the following should happen:

At the nearest GPS position of the SimRa ride, a near miss incident with the incident type "Close Pass" should be created with the following description:

OpenBikeSensor
l: <OpenBikeSensor left sensor value in cm>
r: <OpenBikeSensor right sensor value in cm>

Please mind the line breaks after OpenBikeSensor and .

If either the right or left sensor readings are between -100cm and 150 cm (inclusive in both cases), the incident should be visible to the user and be uploaded, whether the user annotates that incident or not. Such incidents start with a key value of 2000 (,2001, 2002, ...). Their incident type is 1.

Otherwise, the incident should still be created and uploaded but not shown to the user as an incident. Such incidents start with a key value of 3000 (,3001, 3002, ...). Their incident type is -2.

@ckrey
Copy link
Collaborator

ckrey commented Nov 8, 2022

For clarification:

When a user presses the hardware button of the OpenBikeSensor connected to the SimRa App via Bluetooth, the following should happen:
At the nearest GPS position of the SimRa ride, a near miss incident with the incident type "Close Pass" should be created

  • already existing

with the following description:

  • needs to change

If either the right or left sensor readings are between -100cm and 150 cm (inclusive in both cases), the incident should be visible to the user and be uploaded, whether the user annotates that incident or not.

  • currently valid sensor readings are defined as if left or right reading < 150cm

Such incidents start with a key value of 2000 (,2001, 2002, ...). Their incident type is 1.

  • currently all incidents are numbered in one scheme 0(,1, 2, ...)

Otherwise, the incident should still be created and uploaded but not shown to the user as an incident. Such incidents start with a key value of 3000 (,3001, 3002, ...). Their incident type is -2.

  • currently in such a case no incident is created

@selphiron
Copy link
Contributor Author

Yes, these changes should be done, so that the Android and iOS versions behave the same when combined with an OBS

@ckrey
Copy link
Collaborator

ckrey commented Nov 8, 2022

So the key sequence might be:

  • 0
  • 1
  • 2
  • 2000
  • 3
  • 3000
  • 3001
  • 4
  • 5
  • 2001

?

@ckrey
Copy link
Collaborator

ckrey commented Nov 8, 2022

Problem is I will have make the changes without a chance to test (no OBS here)

@selphiron
Copy link
Contributor Author

no, they should be ordered, so

0
1
2
3
4
5
2000
2001
3000
3001

sorry for the very late answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants