Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Scala modeling and refactoring #24

Open
2 tasks
angelcervera opened this issue Jul 8, 2017 · 1 comment
Open
2 tasks

Review Scala modeling and refactoring #24

angelcervera opened this issue Jul 8, 2017 · 1 comment
Labels
enhancement v2 Version 2

Comments

@angelcervera
Copy link
Member

angelcervera commented Jul 8, 2017 •
edited

  • Refactor model to avoid enums / Don't use new Scala 3 enums to keep 2.11 back comp.
  • RelationMemberEntity:relationTypes should be singular instead plural or better call it one type

2017 comments:
For example, in WayEntity.scala it is using Enums and Java style hierarchy.
Two good explanation about why to avoid Enums, at least in Scala:
@angelcervera
Copy link
Member Author

Yes, agree 100% Enums is one of the main reasons to update it. Java mind from 2016 😄

@angelcervera angelcervera added the v2 Version 2 label Oct 22, 2020
@simplexspatial simplexspatial deleted a comment from ericsun95 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement v2 Version 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angelcervera