Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to delete the simplejson/tests directory when creating a binary package(wheel package) #275

Open
tklltkioc opened this issue Jan 29, 2021 · 2 comments

Comments

@tklltkioc
Copy link

tklltkioc commented Jan 29, 2021

OS: centos 7.9
python: 3.8.2

Package    Version
---------- -------
pip        21.0
setuptools 52.0.0
wheel      0.36.2

When i run command python setup.py bdist_wheel,i get the result as follows:
image

After modify setup.py one line

#packages=['simplejson', 'simplejson.tests']
packages=['simplejson']

i get the result as follows:
image

Size compare:
image
delete the simplejson/tests directory could reduce 28kb.

So when running simplejson,whether it is necessary to package the simplejson/tests directory in the wheel package?

@etrepum
Copy link
Member

etrepum commented Jan 29, 2021

This is possible in theory, although it's unknown if this would break anything for anyone who may be running the tests from a wheel for some reason. Can you find an authoritative reference for current Python packaging standards that suggests this is the current best practice?

@tklltkioc
Copy link
Author

OK,I'll try and find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants