Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hledger-web tests fail on stackage #2157

Closed
simonmichael opened this issue Jan 18, 2024 · 9 comments
Closed

hledger-web tests fail on stackage #2157

simonmichael opened this issue Jan 18, 2024 · 9 comments
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. impact1 Affects almost no one. needs:debugging To unblock: needs debugging/investigation needs:external-task To unblock: needs completion of some task/event outside our project needs:repro To unblock: needs a small reproducible example platform:docker severity1 Cleanliness/consistency/developer bug. Only perfectionists care. web The hledger-web tool. wont-fix

Comments

@simonmichael
Copy link
Owner

With setupTerm: Couldn't look up terminfo entry "unknown". Something to do with terminal helpers in Hledger.Utils.IO ?

commercialhaskell/lts-haskell@1342c79

@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. web The hledger-web tool. labels Jan 18, 2024
@juhp
Copy link

juhp commented Jan 19, 2024

(thanks for filing, in the end I hesitated since I wondered if it's a problem on the stackage server env)

@simonmichael simonmichael added severity1 Cleanliness/consistency/developer bug. Only perfectionists care. impact1 Affects almost no one. labels Jan 21, 2024
@simonmichael
Copy link
Owner Author

@juhp: when you have time could you clarify when you see this terminfo "unknown" error, with hledger-web tests ?

I failed to reproduce it with commercialhaskell/stackage#7413.

@simonmichael
Copy link
Owner Author

Notes: hledger-lib's test suite seems currently disabled in stackage (because of issues running doctest). hledger-ui doesn't have a test suite. hledger-web's test suite is the only one using hspec. Most hledger packages import from transitively, even if they don't use, these three terminal-related packages: ansi-terminal, terminal-size, terminfo. Test runners also interact with the terminal.

@simonmichael
Copy link
Owner Author

Pausing this issue in favour of commercialhaskell/stackage#7413

@alaendle
Copy link

Unfortunately the situation remains unchanged:

Running tests for hledger-web 1.33.1, linux-x86_64
test: setupTerm: Couldn't look up terminfo entry "unknown"

@alaendle
Copy link

Okay - pretty sure we just depend on https://packages.ubuntu.com/jammy/ncurses-term to get the "unknown" terminfo ... will re-run with installed package ... and keep you up-to-date ...

@alaendle
Copy link

Hmm - doesn't seem to solve the problem - need to dive deeper ... maybe tomorrow ... (temporarily?) re-disabled tests ... any idea/hint welcome ...

@alaendle
Copy link

I've tried to reproduce this inside the build container - without success - so my best guess is that this has to do with the user things happening here: https://github.com/commercialhaskell/stackage/blob/770b1939dc1784b0484b7f6aeb102c65a1f9cb25/automated/build.sh#L145
But I even tried to mimic this inside the container by creating another user and running nice -n 15 /bin/bash -c "chown other $HOME && exec sudo -E -u other env \"HOME=$HOME\" \"PATH=\$PATH\" ./verify-package hledger-web 2>&1" - but even this succeeds. So at least I have no idea what could be done with justifiable effort - so my suggestion would be to accept the test failure on stackage (as long it doesn't effect more packages) and close this issue without a solution.

@simonmichael
Copy link
Owner Author

Thank you @alaendle. Closing for now per this and the discussion on commercialhaskell/stackage#7413.

@simonmichael simonmichael added wont-fix needs:external-task To unblock: needs completion of some task/event outside our project needs:debugging To unblock: needs debugging/investigation platform:docker needs:repro To unblock: needs a small reproducible example labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. impact1 Affects almost no one. needs:debugging To unblock: needs debugging/investigation needs:external-task To unblock: needs completion of some task/event outside our project needs:repro To unblock: needs a small reproducible example platform:docker severity1 Cleanliness/consistency/developer bug. Only perfectionists care. web The hledger-web tool. wont-fix
Projects
None yet
Development

No branches or pull requests

3 participants