Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible mistake in Deep Q Learning Space Invaders notebook #51

Open
karolisjan opened this issue Apr 22, 2019 · 1 comment
Open

Possible mistake in Deep Q Learning Space Invaders notebook #51

karolisjan opened this issue Apr 22, 2019 · 1 comment

Comments

@karolisjan
Copy link

Hey. Shouldn't self.Q = tf.reduce_sum(tf.multiply(self.output, self.actions_)) in DQN class be self.Q = tf.reduce_sum(tf.multiply(self.output, self.actions_), axis=1), i.e. reduced along columns so that the output length of self.Q is equal to the batch size? If not then self.Q will be a scalar while self.target_Q will be a vector of batch size length.
@ali-ehsan
Copy link

@karolisjan I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ali-ehsan @karolisjan